flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From aljoscha <...@git.apache.org>
Subject [GitHub] flink pull request #5125: [WIP][FLINK-4812][metrics] Expose currentLowWaterm...
Date Wed, 06 Dec 2017 14:53:09 GMT
Github user aljoscha commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5125#discussion_r155257760
  
    --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/TwoInputStreamTask.java
---
    @@ -80,7 +91,10 @@ public void init() throws Exception {
     				this.headOperator);
     
     		// make sure that stream tasks report their I/O statistics
    -		inputProcessor.setMetricGroup(getEnvironment().getMetricGroup().getIOMetricGroup());
    +		inputProcessor.setupMetrics(getEnvironment().getMetricGroup().getIOMetricGroup(), input1WatermarkGauge,
input2WatermarkGauge);
    +
    +		headOperator.getMetricGroup().gauge(MetricNames.IO_CURRENT_INPUT_1_WATERMARK, input1WatermarkGauge);
    --- End diff --
    
    you're thinking: no special magic for input's outputs, no preferences. It's just a fact
that sources will only have an output watermark and no input watermark?


---

Mime
View raw message