flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tillrohrmann <...@git.apache.org>
Subject [GitHub] flink pull request #4991: [FLINK-7928] [runtime] extend the resources in Res...
Date Wed, 06 Dec 2017 11:31:56 GMT
Github user tillrohrmann commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4991#discussion_r155211436
  
    --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/clusterframework/types/ResourceProfile.java
---
    @@ -61,16 +80,26 @@
     	 * @param heapMemoryInMB The size of the heap memory, in megabytes.
     	 * @param directMemoryInMB The size of the direct memory, in megabytes.
     	 * @param nativeMemoryInMB The size of the native memory, in megabytes.
    +	 * @param memoryForInputInMB The size of the memory for input, in megabytes.
    +	 * @param memoryForOutputInMB The size of the memory for output, in megabytes.
     	 */
     	public ResourceProfile(
     			double cpuCores,
     			int heapMemoryInMB,
     			int directMemoryInMB,
    -			int nativeMemoryInMB) {
    +			int nativeMemoryInMB,
    +			int memoryForInputInMB,
    +			int memoryForOutputInMB,
    --- End diff --
    
    For what do we have to differentiate the memory for output and input from the other memory?


---

Mime
View raw message