flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From twalthr <...@git.apache.org>
Subject [GitHub] flink pull request #5065: [FLINK-8139][table] Check for proper equals() and ...
Date Tue, 05 Dec 2017 15:05:42 GMT
Github user twalthr commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5065#discussion_r154968022
  
    --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/TableEnvironment.scala
---
    @@ -721,6 +722,42 @@ abstract class TableEnvironment(val config: TableConfig) {
         */
       protected def checkValidTableName(name: String): Unit
     
    +  /**
    +    * Checks if the chosen table type is valid.
    +    * @param table The table to check
    +    */
    +  protected def checkValidTableType(table: Table): Unit = {
    --- End diff --
    
    Please merge the following three methods into one and move it to companion object.


---

Mime
View raw message