flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From pnowojski <...@git.apache.org>
Subject [GitHub] flink pull request #4533: [FLINK-7416][network] Implement Netty receiver out...
Date Mon, 04 Dec 2017 16:37:11 GMT
Github user pnowojski commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4533#discussion_r154702193
  
    --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/io/network/netty/PartitionRequestClientHandlerTest.java
---
    @@ -244,54 +237,89 @@ public void testCancelBeforeActive() throws Exception {
     	}
     
     	/**
    -	 * Verifies that {@link RemoteInputChannel} is enqueued in the pipeline, and
    -	 * {@link AddCredit} message is sent to the producer.
    +	 * Verifies that {@link RemoteInputChannel} is enqueued in the pipeline for notifying
credits,
    +	 * and verifies the behaviour of credit notification by triggering channel's writability
changed.
     	 */
     	@Test
     	public void testNotifyCreditAvailable() throws Exception {
    +		final SingleInputGate inputGate = createSingleInputGate();
    +		final RemoteInputChannel inputChannel1 = spy(createRemoteInputChannel(inputGate));
    +		final RemoteInputChannel inputChannel2 = spy(createRemoteInputChannel(inputGate));
     		final CreditBasedClientHandler handler = new CreditBasedClientHandler();
    -		final EmbeddedChannel channel = new EmbeddedChannel(handler);
    +		final EmbeddedChannel channel = spy(new EmbeddedChannel(handler));
    --- End diff --
    
    I think this `spy` is not needed anywhere?


---

Mime
View raw message