flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From NicoK <...@git.apache.org>
Subject [GitHub] flink pull request #4533: [FLINK-7416][network] Implement Netty receiver out...
Date Fri, 01 Dec 2017 13:13:36 GMT
Github user NicoK commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4533#discussion_r154337233
  
    --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/RemoteInputChannel.java
---
    @@ -223,11 +229,13 @@ void notifySubpartitionConsumed() {
     	/**
     	 * Releases all exclusive and floating buffers, closes the partition request client.
     	 */
    +	@VisibleForTesting
     	@Override
    -	void releaseAllResources() throws IOException {
    +	public void releaseAllResources() throws IOException {
    --- End diff --
    
    `@VisibleForTesting` or `public` is not needed anymore since you adapted the tests. Please
make it package-private.


---

Mime
View raw message