Mailing-List: contact issues-help@flink.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@flink.apache.org
From: GJL <git@git.apache.org>
To: issues@flink.incubator.apache.org
Reply-To: issues@flink.incubator.apache.org
Message-ID: <git-pr-5082-flink@git.apache.org>
Subject: [GitHub] flink pull request #5082: [FLINK-8143][flip6] Migrate SubtaskMetricsHandler ...
Content-Type: text/plain
Date: Mon, 27 Nov 2017 13:10:41 +0000 (UTC)
archived-at: Mon, 27 Nov 2017 13:10:46 -0000

GitHub user GJL opened a pull request:

    https://github.com/apache/flink/pull/5082

    [FLINK-8143][flip6] Migrate SubtaskMetricsHandler to new RestServerEndpoint

    ## What is the purpose of the change
    
    *FLIP-6 efforts: Migrating HTTP handlers*
    
    ## Brief change log
      - Migrate logic from `org.apache.flink.runtime.rest.handler.legacy.metrics.SubtaskMetricsHandler to` new handler.
      - Add new handler to `DispatcherRestEndpoint`.
    
    ## Verifying this change
    
      - *Added unit tests for all new classes and modified existing classes except for DispatcherRestEndpoint.*
      - *Manually deployed a job locally and verified with `curl` that SubtaskMetrics can be queried in FLIP-6 standalone mode.*
    
    ## Does this pull request potentially affect one of the following parts:
    
      - Dependencies (does it add or upgrade a dependency): (yes / **no**)
      - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)
      - The serializers: (yes / **no** / don't know)
      - The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
      - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)
      - The S3 file system connector: (yes / **no** / don't know)
    
    ## Documentation
    
      - Does this pull request introduce a new feature? (yes / **no**)
      - If yes, how is the feature documented? (**not applicable** / docs / JavaDocs / not documented)
    
    CC: @tillrohrmann 

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/GJL/flink FLINK-8143

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/5082.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #5082
    
----
commit d32d978e1826df6fab8f5b4a27d47b4367d54ece
Author: gyao <gary@data-artisans.com>
Date:   2017-11-27T12:30:18Z

    [FLINK-8150][flip6] Migrate SubtaskMetricsHandler to new RestServerEndpoint
    
    Migrate logic from
    org.apache.flink.runtime.rest.handler.legacy.metrics.SubtaskMetricsHandler to
    new handler. Add new handler to DispatcherRestEndpoint.

commit 96c9f671d6320d5d1d014d5df27f4a3a07417993
Author: gyao <gary@data-artisans.com>
Date:   2017-11-27T12:32:52Z

    [hotfix][Javadoc] Remove wrong Javadoc from SubtaskMetricsHandler

commit c369d733fecc71a7581b5a6cbf196b35ecdfed12
Author: gyao <gary@data-artisans.com>
Date:   2017-11-27T12:34:02Z

    [hotfix][flip6] Add unit tests JobVertexMetricsHeadersTest

----


---