Mailing-List: contact issues-help@flink.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@flink.apache.org
Date: Wed, 29 Nov 2017 11:58:00 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: issues@flink.apache.org
Message-ID: <JIRA.13118516.1510746586000.344783.1511956680245@Atlassian.JIRA>
In-Reply-To: <JIRA.13118516.1510746586000@Atlassian.JIRA>
References: <JIRA.13118516.1510746586000@Atlassian.JIRA> <JIRA.13118516.1510746586639@jira-lw-us.apache.org>
Subject: [jira] [Commented] (FLINK-8080) Remove need for "metrics.reporters"
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Wed, 29 Nov 2017 11:58:06 -0000


    [ https://issues.apache.org/jira/browse/FLINK-8080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16270649#comment-16270649 ] 

ASF GitHub Bot commented on FLINK-8080:
---------------------------------------

GitHub user zentol opened a pull request:

    https://github.com/apache/flink/pull/5099

    [FLINK-8080][metrics] Remove need for "metrics.reporters" config key

    ## What is the purpose of the change
    
    This PR simplifies the reporter configuration by no longer requiring users to explicitly set a list of reporter names via `metrics.reporters`. Instead, the names are automatically determined based on `metrics.reporter.<name>.<option>` keys found in the configuration.
    
    ## Brief change log
    
    * modify reporter configuration parsing to detect reporter names
    * deprecate `MetricOptions.REPORTERS_LIST`
      * remove all usages
      * remove all references from documentation
    
    ## Verifying this change
    
    This change is already covered by existing tests in the various reporter modules that configure a reporter.
    See all tests where `MetricOptions.REPORTERS_LIST` was removed.
    
    ## Does this pull request potentially affect one of the following parts:
    
      - Dependencies (does it add or upgrade a dependency): (no)
      - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
      - The serializers: (no)
      - The runtime per-record code paths (performance sensitive): (no)
      - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
      - The S3 file system connector: (no)
    
    ## Documentation
    
      - Does this pull request introduce a new feature? (yes)
      - If yes, how is the feature documented? (docs)


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/zentol/flink 8080

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/5099.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #5099
    
----
commit 9516d60ffa87ff2d3a42ca0379e95ada0f42b61d
Author: zentol <chesnay@apache.org>
Date:   2017-11-15T11:56:30Z

    [FLINK-8080][metrics] Remove need for "metrics.reporters" config key

----


> Remove need for "metrics.reporters"
> -----------------------------------
>
>                 Key: FLINK-8080
>                 URL: https://issues.apache.org/jira/browse/FLINK-8080
>             Project: Flink
>          Issue Type: Improvement
>          Components: Configuration, Metrics
>            Reporter: Chesnay Schepler
>            Assignee: Chesnay Schepler
>            Priority: Trivial
>             Fix For: 1.5.0
>
>
> Currently, in order to use a reporter one must configure something like this:
> {code}
> metrics.reporters: jmx
> metrics.reporter.jmx.class: ...
> {code}
> It would be neat if users did not have to set {{metrics.reporters}}. We can accomplish this by a scanning the configuration for configuration keys starting with {{metrics.reporter.}} and using the next word as a reporter name.


--
This message was sent by Atlassian JIRA
(v6.4.14#64029)