Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id BB548200D3C for ; Tue, 14 Nov 2017 23:38:04 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id B9D2D160C07; Tue, 14 Nov 2017 22:38:04 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 147B7160BD7 for ; Tue, 14 Nov 2017 23:38:03 +0100 (CET) Received: (qmail 42676 invoked by uid 500); 14 Nov 2017 22:38:03 -0000 Mailing-List: contact issues-help@flink.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@flink.apache.org Delivered-To: mailing list issues@flink.apache.org Received: (qmail 42660 invoked by uid 99); 14 Nov 2017 22:38:03 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 14 Nov 2017 22:38:03 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 905FC1A1BB5 for ; Tue, 14 Nov 2017 22:38:02 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -100.002 X-Spam-Level: X-Spam-Status: No, score=-100.002 tagged_above=-999 required=6.31 tests=[RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id hvQAgivFNBvX for ; Tue, 14 Nov 2017 22:38:02 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id BBE355F299 for ; Tue, 14 Nov 2017 22:38:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 1E795E0E7A for ; Tue, 14 Nov 2017 22:38:01 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id A6754240DE for ; Tue, 14 Nov 2017 22:38:00 +0000 (UTC) Date: Tue, 14 Nov 2017 22:38:00 +0000 (UTC) From: "Ted Yu (JIRA)" To: issues@flink.apache.org Message-ID: In-Reply-To: References:

Subject: [jira] [Created] (FLINK-8075) Redundant clone() in Configuration ctor MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Tue, 14 Nov 2017 22:38:04 -0000 Ted Yu created FLINK-8075: ----------------------------- Summary: Redundant clone() in Configuration ctor Key: FLINK-8075 URL: https://issues.apache.org/jira/browse/FLINK-8075 Project: Flink Issue Type: Bug Reporter: Ted Yu Priority: Minor In flink-filesystems/flink-s3-fs-presto/src/main/java/org/apache/hadoop/conf/Configuration.java , at line 703: {code} public Configuration(Configuration other) { this.resources = (ArrayList) other.resources.clone(); synchronized(other) { if (other.properties != null) { this.properties = (Properties)other.properties.clone(); } {code} The first clone() call is without synchronization and without null check. -- This message was sent by Atlassian JIRA (v6.4.14#64029)