Mailing-List: contact issues-help@flink.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@flink.apache.org
Date: Tue, 14 Nov 2017 17:10:00 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: issues@flink.apache.org
Message-ID: <JIRA.13115967.1509724684000.235144.1510679400684@Atlassian.JIRA>
In-Reply-To: <JIRA.13115967.1509724684000@Atlassian.JIRA>
References: <JIRA.13115967.1509724684000@Atlassian.JIRA> <JIRA.13115967.1509724684156@jira-lw-us.apache.org>
Subject: [jira] [Commented] (FLINK-7974) AbstractServerBase#shutdown does
 not wait for shutdown completion
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Tue, 14 Nov 2017 17:10:07 -0000


    [ https://issues.apache.org/jira/browse/FLINK-7974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16251749#comment-16251749 ] 

ASF GitHub Bot commented on FLINK-7974:
---------------------------------------

Github user aljoscha commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4993#discussion_r150890435
  
    --- Diff: flink-queryable-state/flink-queryable-state-client-java/src/main/java/org/apache/flink/queryablestate/network/Client.java ---
    @@ -208,9 +239,15 @@ public void shutdown() {
     		/** The established connection after the connect succeeds. */
     		private EstablishedConnection established;
     
    +		/** Atomic shut down future. */
    +		private final AtomicReference<CompletableFuture<?>> connectionShutdownFuture = new AtomicReference<>(null);
    +
     		/** Closed flag. */
     		private boolean closed;
     
    +//		/** Shut down future. */
    --- End diff --
    
    ?


> AbstractServerBase#shutdown does not wait for shutdown completion
> -----------------------------------------------------------------
>
>                 Key: FLINK-7974
>                 URL: https://issues.apache.org/jira/browse/FLINK-7974
>             Project: Flink
>          Issue Type: Bug
>          Components: Queryable State
>    Affects Versions: 1.4.0
>            Reporter: Till Rohrmann
>            Assignee: Kostas Kloudas
>            Priority: Critical
>
> The {{AbstractServerBase}} does not wait for the completion of its shutdown when calling {{AbstractServerBase#shutdown}}. This is problematic since it leads to resource leaks and instable tests such as the {{AbstractServerTest}}. I propose to let the {{AbstractServerBase#shutdown}} return a termination future which is completed upon shutdown completion.


--
This message was sent by Atlassian JIRA
(v6.4.14#64029)