Mailing-List: contact issues-help@flink.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@flink.apache.org
Date: Thu, 2 Nov 2017 13:53:03 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: issues@flink.apache.org
Message-ID: <JIRA.13097279.1503568393000.131458.1509630783263@Atlassian.JIRA>
In-Reply-To: <JIRA.13097279.1503568393000@Atlassian.JIRA>
References: <JIRA.13097279.1503568393000@Atlassian.JIRA> <JIRA.13097279.1503568393389@jira-lw-us.apache.org>
Subject: [jira] [Commented] (FLINK-7499) double buffer release in
 SpillableSubpartitionView
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Thu, 02 Nov 2017 13:53:11 -0000


    [ https://issues.apache.org/jira/browse/FLINK-7499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16235764#comment-16235764 ] 

ASF GitHub Bot commented on FLINK-7499:
---------------------------------------

Github user pnowojski commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4581#discussion_r148531416
  
    --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/SpillableSubpartitionView.java ---
    @@ -108,11 +108,7 @@ int releaseMemory() throws IOException {
     				for (int i = 0; i < numBuffers; i++) {
     					Buffer buffer = buffers.remove();
     					spilledBytes += buffer.getSize();
    -					try {
    -						spillWriter.writeBlock(buffer);
    -					} finally {
    -						buffer.recycle();
    -					}
    +					spillWriter.writeBlock(buffer);
    --- End diff --
    
    Here is the place where you depend on recycling which is not guaranteed by `spillWriter`'s interface.


> double buffer release in SpillableSubpartitionView
> --------------------------------------------------
>
>                 Key: FLINK-7499
>                 URL: https://issues.apache.org/jira/browse/FLINK-7499
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Network
>    Affects Versions: 1.2.0, 1.1.4, 1.3.0, 1.1.5, 1.2.1, 1.2.2, 1.3.1, 1.4.0, 1.3.2, 1.3.3
>            Reporter: Nico Kruber
>            Assignee: Nico Kruber
>            Priority: Blocker
>
> {{SpillableSubpartitionView#releaseMemory()}} recycles its buffers twice: once asynchronously after the write operation and once in {{SpillableSubpartitionView#releaseMemory()}} after adding the write operation to the queue.
> 1) if {{SpillableSubpartitionView#releaseMemory()}} hits first and the buffer is recycled, the memory region may already be reused despite the pending write
> 2) If, for some reason (probably only in tests like {{SpillableSubpartitionTest#testConsumeSpillablePartitionSpilledDuringConsume()}}?), the buffer is retained and to be used in parallel somewhere else it may also not be available anymore or contain corrupt data.


--
This message was sent by Atlassian JIRA
(v6.4.14#64029)