Mailing-List: contact issues-help@flink.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@flink.apache.org
Date: Wed, 29 Nov 2017 10:42:00 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: issues@flink.apache.org
Message-ID: <JIRA.13011623.1476266107000.344411.1511952120386@Atlassian.JIRA>
In-Reply-To: <JIRA.13011623.1476266107000@Atlassian.JIRA>
References: <JIRA.13011623.1476266107000@Atlassian.JIRA> <JIRA.13011623.1476266107772@jira-lw-us.apache.org>
Subject: [jira] [Commented] (FLINK-4812) Report Watermark metrics in all
 operators
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Wed, 29 Nov 2017 10:42:05 -0000


    [ https://issues.apache.org/jira/browse/FLINK-4812?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16270569#comment-16270569 ] 

ASF GitHub Bot commented on FLINK-4812:
---------------------------------------

Github user zentol commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5092#discussion_r153750429
  
    --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/metrics/WatermarkGauge.java ---
    @@ -0,0 +1,38 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.flink.streaming.runtime.metrics;
    +
    +import org.apache.flink.metrics.Gauge;
    +
    +/**
    + * A {@link Gauge} for exposing the current low watermark.
    + */
    +public class WatermarkGauge implements Gauge<Long> {
    +
    +	private long currentLowWatermark = Long.MIN_VALUE;
    +
    +	public void setCurrentLowWatermark(long watermark) {
    +		this.currentLowWatermark = watermark;
    --- End diff --
    
    I was hesitant since it would be additional runtime overhead for watermark processing that, as i understand it, should be unnecessary assuming a correct source/watermark assigner implementation.


> Report Watermark metrics in all operators
> -----------------------------------------
>
>                 Key: FLINK-4812
>                 URL: https://issues.apache.org/jira/browse/FLINK-4812
>             Project: Flink
>          Issue Type: Improvement
>          Components: Metrics
>            Reporter: Robert Metzger
>            Assignee: Chesnay Schepler
>            Priority: Critical
>             Fix For: 1.5.0
>
>
> As reported by a user, Flink does currently not export the current low watermark for sources (http://apache-flink-mailing-list-archive.1008284.n3.nabble.com/currentLowWatermark-metric-not-reported-for-all-tasks-td13770.html).
> This JIRA is for adding such a metric for the sources as well.


--
This message was sent by Atlassian JIRA
(v6.4.14#64029)