Mailing-List: contact issues-help@flink.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@flink.apache.org
Date: Tue, 14 Nov 2017 14:18:01 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: issues@flink.apache.org
Message-ID: <JIRA.13000202.1472165562000.233057.1510669081583@Atlassian.JIRA>
In-Reply-To: <JIRA.13000202.1472165562000@Atlassian.JIRA>
References: <JIRA.13000202.1472165562000@Atlassian.JIRA> <JIRA.13000202.1472165562299@jira-lw-us.apache.org>
Subject: [jira] [Commented] (FLINK-4500) Cassandra sink can lose messages
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Tue, 14 Nov 2017 14:18:07 -0000


    [ https://issues.apache.org/jira/browse/FLINK-4500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16251434#comment-16251434 ] 

ASF GitHub Bot commented on FLINK-4500:
---------------------------------------

Github user asfgit closed the pull request at:

    https://github.com/apache/flink/pull/5002


> Cassandra sink can lose messages
> --------------------------------
>
>                 Key: FLINK-4500
>                 URL: https://issues.apache.org/jira/browse/FLINK-4500
>             Project: Flink
>          Issue Type: Bug
>          Components: Cassandra Connector
>    Affects Versions: 1.1.0
>            Reporter: Elias Levy
>            Assignee: Michael Fong
>             Fix For: 1.4.0
>
>
> The problem is the same as I pointed out with the Kafka producer sink (FLINK-4027).  The CassandraTupleSink's send() and CassandraPojoSink's send() both send data asynchronously to Cassandra and record whether an error occurs via a future callback.  But CassandraSinkBase does not implement Checkpointed, so it can't stop checkpoint from happening even though the are Cassandra queries in flight from the checkpoint that may fail.  If they do fail, they would subsequently not be replayed when the job recovered, and would thus be lost.
> In addition, 
> CassandraSinkBase's close should check whether there is a pending exception and throw it, rather than silently close.  It should also wait for any pending async queries to complete and check their status before closing.


--
This message was sent by Atlassian JIRA
(v6.4.14#64029)