Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id D2B65200D4C for ; Thu, 30 Nov 2017 10:46:28 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id D11A7160BF4; Thu, 30 Nov 2017 09:46:28 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 251DE160BEA for ; Thu, 30 Nov 2017 10:46:27 +0100 (CET) Received: (qmail 40745 invoked by uid 500); 30 Nov 2017 09:46:27 -0000 Mailing-List: contact issues-help@flink.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@flink.apache.org Delivered-To: mailing list issues@flink.apache.org Received: (qmail 40736 invoked by uid 99); 30 Nov 2017 09:46:27 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 30 Nov 2017 09:46:27 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id E6C501A0FC9 for ; Thu, 30 Nov 2017 09:46:26 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -4.021 X-Spam-Level: X-Spam-Status: No, score=-4.021 tagged_above=-999 required=6.31 tests=[KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RP_MATCHES_RCVD=-0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id OQjJa0uJNLGJ for ; Thu, 30 Nov 2017 09:46:26 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with SMTP id BB74F5F39D for ; Thu, 30 Nov 2017 09:46:25 +0000 (UTC) Received: (qmail 40706 invoked by uid 99); 30 Nov 2017 09:46:25 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 30 Nov 2017 09:46:25 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 5B839E10C5; Thu, 30 Nov 2017 09:46:23 +0000 (UTC) From: NicoK To: issues@flink.incubator.apache.org Reply-To: issues@flink.incubator.apache.org References: In-Reply-To: Subject: [GitHub] flink pull request #4533: [FLINK-7416][network] Implement Netty receiver out... Content-Type: text/plain Message-Id: <20171130094624.5B839E10C5@git1-us-west.apache.org> Date: Thu, 30 Nov 2017 09:46:23 +0000 (UTC) archived-at: Thu, 30 Nov 2017 09:46:29 -0000 Github user NicoK commented on a diff in the pull request: https://github.com/apache/flink/pull/4533#discussion_r154026730 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/netty/NettyMessage.java --- @@ -584,4 +587,60 @@ static CloseRequest readFrom(@SuppressWarnings("unused") ByteBuf buffer) throws return new CloseRequest(); } } + + static class AddCredit extends NettyMessage { + + private static final byte ID = 6; + + final ResultPartitionID partitionId; + + final int credit; + + final InputChannelID receiverId; + + AddCredit(ResultPartitionID partitionId, int credit, InputChannelID receiverId) { + this.partitionId = partitionId; + this.credit = credit; --- End diff -- oh, yes, you're right - I meant `>= 1` of course regarding `PartitionRequest`, this makes sense ---