Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id AB979200D49 for ; Fri, 24 Nov 2017 11:38:15 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id AA175160BF2; Fri, 24 Nov 2017 10:38:15 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id EF15B160BEE for ; Fri, 24 Nov 2017 11:38:14 +0100 (CET) Received: (qmail 26973 invoked by uid 500); 24 Nov 2017 10:38:14 -0000 Mailing-List: contact issues-help@flink.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@flink.apache.org Delivered-To: mailing list issues@flink.apache.org Received: (qmail 26964 invoked by uid 99); 24 Nov 2017 10:38:14 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 24 Nov 2017 10:38:14 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 73ACFC4B06 for ; Fri, 24 Nov 2017 10:38:13 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -3.83 X-Spam-Level: X-Spam-Status: No, score=-3.83 tagged_above=-999 required=6.31 tests=[KAM_LAZY_DOMAIN_SECURITY=1, KB_WAM_FROM_NAME_SINGLEWORD=0.2, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, T_RP_MATCHES_RCVD=-0.01] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id ubcvGHgdMMSW for ; Fri, 24 Nov 2017 10:38:12 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with SMTP id 523065FD10 for ; Fri, 24 Nov 2017 10:38:12 +0000 (UTC) Received: (qmail 26955 invoked by uid 99); 24 Nov 2017 10:38:11 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 24 Nov 2017 10:38:11 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id AF2E0DFF66; Fri, 24 Nov 2017 10:38:11 +0000 (UTC) From: StefanRRichter To: issues@flink.incubator.apache.org Reply-To: issues@flink.incubator.apache.org References: In-Reply-To: Subject: [GitHub] flink issue #5058: [FLINK-5465] [streaming] Wait for pending timer threads t... Content-Type: text/plain Message-Id: <20171124103811.AF2E0DFF66@git1-us-west.apache.org> Date: Fri, 24 Nov 2017 10:38:11 +0000 (UTC) archived-at: Fri, 24 Nov 2017 10:38:15 -0000 Github user StefanRRichter commented on the issue: https://github.com/apache/flink/pull/5058 I was thinking about where to put those options and after all it was a choice between fragmentation and inconsistency. I considered `TaskManagerOptions` but it sounds like a wrong place, if you look what the other options in this class are about and it also feels like saying `Task` == `StreamTask` because timers are something that currently belongs to `streaming` imo. There are classes for configurations all over the place, so if you think this is a problem, maybe we should fix it in general and not on a per-case basis? I agree that we can change the key string. ---