Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 6918F200D44 for ; Mon, 20 Nov 2017 15:51:58 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 65B49160BEC; Mon, 20 Nov 2017 14:51:58 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 30592160BF9 for ; Mon, 20 Nov 2017 15:51:57 +0100 (CET) Received: (qmail 27815 invoked by uid 500); 20 Nov 2017 14:51:56 -0000 Mailing-List: contact issues-help@flink.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@flink.apache.org Delivered-To: mailing list issues@flink.apache.org Received: (qmail 27736 invoked by uid 99); 20 Nov 2017 14:51:56 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 20 Nov 2017 14:51:56 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 9E117180739 for ; Mon, 20 Nov 2017 14:51:55 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -4.021 X-Spam-Level: X-Spam-Status: No, score=-4.021 tagged_above=-999 required=6.31 tests=[KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RP_MATCHES_RCVD=-0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id UA5io52q7qHU for ; Mon, 20 Nov 2017 14:51:54 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with SMTP id E78585FE5C for ; Mon, 20 Nov 2017 14:51:53 +0000 (UTC) Received: (qmail 26659 invoked by uid 99); 20 Nov 2017 14:51:53 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 20 Nov 2017 14:51:53 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 19683F4F66; Mon, 20 Nov 2017 14:51:53 +0000 (UTC) From: pnowojski To: issues@flink.incubator.apache.org Reply-To: issues@flink.incubator.apache.org References: In-Reply-To: Subject: [GitHub] flink pull request #4559: [FLINK-7468][network] Implement sender backlog log... Content-Type: text/plain Message-Id: <20171120145153.19683F4F66@git1-us-west.apache.org> Date: Mon, 20 Nov 2017 14:51:53 +0000 (UTC) archived-at: Mon, 20 Nov 2017 14:51:58 -0000 Github user pnowojski commented on a diff in the pull request: https://github.com/apache/flink/pull/4559#discussion_r152008483 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/SpillableSubpartition.java --- @@ -246,9 +246,9 @@ public int unsynchronizedGetNumberOfQueuedBuffers() { @Override public String toString() { return String.format("SpillableSubpartition [%d number of buffers (%d bytes)," + - "finished? %s, read view? %s, spilled? %s]", - getTotalNumberOfBuffers(), getTotalNumberOfBytes(), isFinished, readView != null, - spillWriter != null); + "%d backlog, finished? %s, read view? %s, spilled? %s]", --- End diff -- `"%d buffers in backlog, finished (...)"` ? `"backlog = %d, finished (...)"` ? `"%d in backlog, finished (...)"` ? `%d backlog` is a little bit cryptic. ---