Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id DF3C6200D3C for ; Tue, 14 Nov 2017 09:05:55 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id DDAE3160BF4; Tue, 14 Nov 2017 08:05:55 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 320EC1609EF for ; Tue, 14 Nov 2017 09:05:55 +0100 (CET) Received: (qmail 94678 invoked by uid 500); 14 Nov 2017 08:05:54 -0000 Mailing-List: contact issues-help@flink.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@flink.apache.org Delivered-To: mailing list issues@flink.apache.org Received: (qmail 94669 invoked by uid 99); 14 Nov 2017 08:05:54 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 14 Nov 2017 08:05:54 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 4BED41A06DB for ; Tue, 14 Nov 2017 08:05:53 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -4.02 X-Spam-Level: X-Spam-Status: No, score=-4.02 tagged_above=-999 required=6.31 tests=[KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RP_MATCHES_RCVD=-0.001, URIBL_BLOCKED=0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id rBIExL_VgbzW for ; Tue, 14 Nov 2017 08:05:52 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with SMTP id 203795FD41 for ; Tue, 14 Nov 2017 08:05:51 +0000 (UTC) Received: (qmail 94411 invoked by uid 99); 14 Nov 2017 08:05:51 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 14 Nov 2017 08:05:51 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 780B2DFF58; Tue, 14 Nov 2017 08:05:51 +0000 (UTC) From: pnowojski To: issues@flink.incubator.apache.org Reply-To: issues@flink.incubator.apache.org References: In-Reply-To: Subject: [GitHub] flink pull request #5007: [FLINK-7845] Make NettyMessage public Content-Type: text/plain Message-Id: <20171114080551.780B2DFF58@git1-us-west.apache.org> Date: Tue, 14 Nov 2017 08:05:51 +0000 (UTC) archived-at: Tue, 14 Nov 2017 08:05:56 -0000 Github user pnowojski commented on a diff in the pull request: https://github.com/apache/flink/pull/5007#discussion_r150759972 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/netty/NettyMessage.java --- @@ -52,8 +52,10 @@ /** * A simple and generic interface to serialize messages to Netty's buffer space. + * + *

This class must be public as long as we are using Netty 4.0.x. Please check FLINK-7845 for more information. --- End diff -- added specific Netty version. ---