Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id AEBC1200D37 for ; Thu, 9 Nov 2017 15:53:06 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id AD559160BEF; Thu, 9 Nov 2017 14:53:06 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id F2CBF1609E5 for ; Thu, 9 Nov 2017 15:53:05 +0100 (CET) Received: (qmail 91664 invoked by uid 500); 9 Nov 2017 14:53:05 -0000 Mailing-List: contact issues-help@flink.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@flink.apache.org Delivered-To: mailing list issues@flink.apache.org Received: (qmail 91655 invoked by uid 99); 9 Nov 2017 14:53:05 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 09 Nov 2017 14:53:05 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 67B24D4E85 for ; Thu, 9 Nov 2017 14:53:04 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -4.02 X-Spam-Level: X-Spam-Status: No, score=-4.02 tagged_above=-999 required=6.31 tests=[KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RP_MATCHES_RCVD=-0.001, URIBL_BLOCKED=0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id s2-kMvo3vDXp for ; Thu, 9 Nov 2017 14:53:03 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with SMTP id 1918E60FCC for ; Thu, 9 Nov 2017 14:53:02 +0000 (UTC) Received: (qmail 91627 invoked by uid 99); 9 Nov 2017 14:53:02 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 09 Nov 2017 14:53:02 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 8E2D9DFB77; Thu, 9 Nov 2017 14:53:01 +0000 (UTC) From: kl0u To: issues@flink.incubator.apache.org Reply-To: issues@flink.incubator.apache.org References: In-Reply-To: Subject: [GitHub] flink pull request #4980: [FLINK-8005] [runtime] Set user code class loader ... Content-Type: text/plain Message-Id: <20171109145301.8E2D9DFB77@git1-us-west.apache.org> Date: Thu, 9 Nov 2017 14:53:01 +0000 (UTC) archived-at: Thu, 09 Nov 2017 14:53:06 -0000 Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/4980#discussion_r149982812 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/taskmanager/TaskAsyncCallTest.java --- @@ -277,8 +287,12 @@ public void invoke() throws Exception { } } - triggerLatch.trigger(); if (error != null) { + // exit method prematurely due to error but make sure that the tests can finish + triggerLatch.trigger(); --- End diff -- for all latches, it should also have:`if (!latch.isTriggered()) { latch.await() }` ---