Mailing-List: contact issues-help@flink.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@flink.apache.org
From: tillrohrmann <git@git.apache.org>
To: issues@flink.incubator.apache.org
Reply-To: issues@flink.incubator.apache.org
References: <git-pr-4911-flink@git.apache.org>
In-Reply-To: <git-pr-4911-flink@git.apache.org>
Subject: [GitHub] flink pull request #4911: [FLINK-7878] [api] make resource type extendible i...
Content-Type: text/plain
Message-Id: <20171106150418.23E14DF97F@git1-us-west.apache.org>
Date: Mon,  6 Nov 2017 15:04:18 +0000 (UTC)
archived-at: Mon, 06 Nov 2017 15:04:24 -0000

Github user tillrohrmann commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4911#discussion_r149098202
  
    --- Diff: flink-core/src/main/java/org/apache/flink/api/common/operators/ResourceSpec.java ---
    @@ -183,17 +238,81 @@ public int hashCode() {
     		result = 31 * result + directMemoryInMB;
     		result = 31 * result + nativeMemoryInMB;
     		result = 31 * result + stateSizeInMB;
    +		result = 31 * result + extendedResources.hashCode();
     		return result;
     	}
     
     	@Override
     	public String toString() {
    +		String extend = "";
    +		for (Resource resource : extendedResources.values()) {
    +			extend += ", " + resource.name + "=" + resource.value;
    +		}
     		return "ResourceSpec{" +
     				"cpuCores=" + cpuCores +
     				", heapMemoryInMB=" + heapMemoryInMB +
     				", directMemoryInMB=" + directMemoryInMB +
     				", nativeMemoryInMB=" + nativeMemoryInMB +
    -				", stateSizeInMB=" + stateSizeInMB +
    +				", stateSizeInMB=" + stateSizeInMB + extend +
     				'}';
     	}
    +
    +	private void addResource(String name, double value, ResourceAggregateType type) {
    +		extendedResources.put(name, new Resource(name, type, value));
    +	}
    +
    +	public static class Resource {
    +		private String name;
    +		private ResourceAggregateType type;
    +		private Double value;
    +
    +		public Resource(String name, double value) {
    +			this(name, ResourceAggregateType.AGGREGATE_TYPE_SUM, value);
    --- End diff --
    
    `ResourceAggregateType` should be the last argument since `name` and `value` are properly passed to this method.


---