Return-Path: <issues-return-138443-archive-asf-public=cust-asf.ponee.io@flink.apache.org>
X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io
Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io
Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183])
	by cust-asf2.ponee.io (Postfix) with ESMTP id 0CF3C200D2F
	for <archive-asf-public-internal@cust-asf2.ponee.io>; Wed,  1 Nov 2017 12:46:03 +0100 (CET)
Received: by cust-asf.ponee.io (Postfix)
	id 0B5E2160BFA; Wed,  1 Nov 2017 11:46:03 +0000 (UTC)
Delivered-To: archive-asf-public@cust-asf.ponee.io
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by cust-asf.ponee.io (Postfix) with SMTP id 51F77160BE6
	for <archive-asf-public@cust-asf.ponee.io>; Wed,  1 Nov 2017 12:46:02 +0100 (CET)
Received: (qmail 82495 invoked by uid 500); 1 Nov 2017 11:46:01 -0000
Mailing-List: contact issues-help@flink.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:issues-help@flink.apache.org>
List-Unsubscribe: <mailto:issues-unsubscribe@flink.apache.org>
List-Post: <mailto:issues@flink.apache.org>
List-Id: <issues.flink.apache.org>
Reply-To: dev@flink.apache.org
Delivered-To: mailing list issues@flink.apache.org
Received: (qmail 82485 invoked by uid 99); 1 Nov 2017 11:46:01 -0000
Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142)
    by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 01 Nov 2017 11:46:01 +0000
Received: from localhost (localhost [127.0.0.1])
	by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id CAA791807F7
	for <issues@flink.apache.org>; Wed,  1 Nov 2017 11:46:00 +0000 (UTC)
X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org
X-Spam-Flag: NO
X-Spam-Score: -4.021
X-Spam-Level: 
X-Spam-Status: No, score=-4.021 tagged_above=-999 required=6.31
	tests=[KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_DNSWL_HI=-5,
	RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01,
	RP_MATCHES_RCVD=-0.001] autolearn=disabled
Received: from mx1-lw-us.apache.org ([10.40.0.8])
	by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024)
	with ESMTP id C86e4F5XsyYE for <issues@flink.apache.org>;
	Wed,  1 Nov 2017 11:46:00 +0000 (UTC)
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with SMTP id DA2705FDAB
	for <issues@flink.incubator.apache.org>; Wed,  1 Nov 2017 11:45:59 +0000 (UTC)
Received: (qmail 82441 invoked by uid 99); 1 Nov 2017 11:45:59 -0000
Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23)
    by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 01 Nov 2017 11:45:59 +0000
Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33)
	id 59BB0DFB6F; Wed,  1 Nov 2017 11:45:59 +0000 (UTC)
From: XuPingyong <git@git.apache.org>
To: issues@flink.incubator.apache.org
Reply-To: issues@flink.incubator.apache.org
References: <git-pr-2110-flink@git.apache.org>
In-Reply-To: <git-pr-2110-flink@git.apache.org>
Subject: [GitHub] flink issue #2110: [FLINK-3974] Fix object reuse with multi-chaining
Content-Type: text/plain
Message-Id: <20171101114559.59BB0DFB6F@git1-us-west.apache.org>
Date: Wed,  1 Nov 2017 11:45:59 +0000 (UTC)
archived-at: Wed, 01 Nov 2017 11:46:03 -0000

Github user XuPingyong commented on the issue:

    https://github.com/apache/flink/pull/2110
  
    I do not agree with this pr as it always copy  StreamRecord to downstream operator.
    
    StreamMap change the input StreamRecord, so this pr works well. But many operators do not change/reuse the input StreamRecord, like StreamFlatMap.
    
    The following code no not need the extra copy.
    `DataStream<A> input = ...
    input
        .flatmap(FlatMapFunction<A,B>...)
        .addSink(...);
    
    input
        .flatmap(FlatMapFunction<A,C>...)
        ​.addSink(...);`
    
        So I think we can change StreamMap to not reuse the input StreamRecord. And directly send the StreamRecord if objectReuse is set true.  
        What do you think?


---