flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From StephanEwen <...@git.apache.org>
Subject [GitHub] flink pull request #4938: [FLINK-7968] [core] Move DataOutputSerializer and ...
Date Thu, 02 Nov 2017 17:55:35 GMT
GitHub user StephanEwen opened a pull request:


    [FLINK-7968] [core] Move DataOutputSerializer and DataInputDeserializer to 'flink-core'

    ## What is the purpose of the change
    This moves the classes `DataInputDeserializer` and `DataOutputSerializer` to `flink-core`,
because these classes are used across difference projects (`flink-runtime` and `flink-queryable-state`)
and were previously duplicated.
    This is also needed for future cleanup in the proper scoping of `SerializationSchema`.
    It is easily possible, because these classes have no dependencies on other Flink classes
    ## Changelog
      - Move `DataInputDeserializer` and `DataOutputSerializer` to `flink-core`
      - Move associated tests and test utils to `flink-core`
      - Delete the duplicate serializers in `flink-queryable-state`.
    ## Verifying this change
    This change is a trivial rework / code cleanup which is covered by existing tests.
    ## Does this pull request potentially affect one of the following parts:
      - Dependencies (does it add or upgrade a dependency): (yes / **no**)
      - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes
/ **no**)
      - The serializers: (yes / **no** / don't know)
      - The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
      - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing,
Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)
    ## Documentation
      - Does this pull request introduce a new feature? (yes / **no**)
      - If yes, how is the feature documented? (**not applicable** / docs / JavaDocs / not

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/StephanEwen/incubator-flink move_data_in_out

Alternatively you can review and apply these changes as the patch at:


To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #4938
commit 6afd68b100edab4689a6e7a39b5aee7743e05853
Author: Stephan Ewen <sewen@apache.org>
Date:   2017-11-02T16:19:19Z

    [hotfix] [tests] Improve TypeInfoTestCoverageTest

commit 4d808a456d698253b2a77cc79e7d4386ceeab706
Author: Stephan Ewen <sewen@apache.org>
Date:   2017-11-02T17:27:23Z

    [FLINK-7968] [core] Move DataOutputSerializer and DataInputDeserializer to 'flink-core'
    These core flink utils are independent of any other runtime classes and
    are also used both in flink-runtime and in flink-queryable-state (which duplicated
    the code).



View raw message