flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-8149) Replace usages of deprecated SerializationSchema
Date Mon, 27 Nov 2017 09:16:01 GMT

    [ https://issues.apache.org/jira/browse/FLINK-8149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16266539#comment-16266539
] 

ASF GitHub Bot commented on FLINK-8149:
---------------------------------------

Github user tzulitai commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5069#discussion_r153139738
  
    --- Diff: flink-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/FlinkKinesisConsumer.java
---
    @@ -41,7 +42,6 @@
     import org.apache.flink.streaming.connectors.kinesis.serialization.KinesisDeserializationSchema;
     import org.apache.flink.streaming.connectors.kinesis.serialization.KinesisDeserializationSchemaWrapper;
     import org.apache.flink.streaming.connectors.kinesis.util.KinesisConfigUtil;
    -import org.apache.flink.streaming.util.serialization.DeserializationSchema;
    --- End diff --
    
    I think we can not simply remove the usage of this, as that will be an user API-breaking
change (for users that use the `FlinkKinesisConsumer(String, DeserializationSchema<T>,
Properties)` constructor).
    
    Instead of removing this, we should deprecate the constructors that accept the deprecated
`DeserializationSchema` interface, and add new corresponding constructors that accept the
new migrated `DeserializationSchema`.


> Replace usages of deprecated SerializationSchema
> ------------------------------------------------
>
>                 Key: FLINK-8149
>                 URL: https://issues.apache.org/jira/browse/FLINK-8149
>             Project: Flink
>          Issue Type: Improvement
>          Components: Kinesis Connector
>    Affects Versions: 1.4.0
>            Reporter: Hai Zhou UTC+8
>            Assignee: Hai Zhou UTC+8
>             Fix For: 1.5.0
>
>
> The deprecated {{SerializationSchema}}  in {{flink-streaming-java}}, has been moved to
{{flink-core}}.
> But, the deprecate {{SerializationSchema}} is still used in {{flink-connector-kinesis}}.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message