flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-8122) Name all table sinks and sources
Date Mon, 27 Nov 2017 12:12:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-8122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16266715#comment-16266715
] 

ASF GitHub Bot commented on FLINK-8122:
---------------------------------------

Github user xccui commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5068#discussion_r153179456
  
    --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/sources/TableSource.scala
---
    @@ -60,4 +60,14 @@ trait TableSource[T] {
         */
       def explainSource(): String = ""
     
    +  /**
    +    * Gets the name which is used by the visualization and logging during runtime.
    +    *
    +    * @return Name of the [[TableSource]].
    +    */
    +  def getRuntimeName(): String = {
    --- End diff --
    
    Hi @fhueske, thanks for the suggestion. I'll remove this method and add a default implementation
for `explainSource()`.


> Name all table sinks and sources
> --------------------------------
>
>                 Key: FLINK-8122
>                 URL: https://issues.apache.org/jira/browse/FLINK-8122
>             Project: Flink
>          Issue Type: Improvement
>          Components: Table API & SQL
>    Affects Versions: 1.4.0
>            Reporter: Timo Walther
>            Assignee: Xingcan Cui
>
> Not all table sink and sources have proper names. Therefore, they are displayed as "Unnamed"
in the logs and Web UI (e.g. CsvTableSink). We should add names for all built-in connectors.
Having information about the table sink name (via {{INSERT INTO}}) would be even better.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message