flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-8110) fasterxml jackson services are not relocated
Date Mon, 20 Nov 2017 13:33:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-8110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16259244#comment-16259244

ASF GitHub Bot commented on FLINK-8110:

GitHub user zentol opened a pull request:


    [FLINK-8110][dist] Relocate jackson services in flink-dist

    ## What is the purpose of the change
    This PR introduces a com.fasterxml.jackson relocation to flink-dist in order to relocate
the jackson services contained in flink-shaded-jackson. The flink-shaded project still uses
shade-plugin 2.4.1 which doesn't relocate services.
    Since flink also doesn't use 3.0.0 yet we have to manually bump the version in flink-dist.
    ## Brief change log
    * bump maven-shade-plugin version in flink-dist to 3.0.0
    * add com.fasterxml.jackson relocation
    ## Verifying this change
    * build flink-dist and check the contents of META-INF/services
      * it should contain the following files:
        `org.apache.flink.shaded.jackson2.com.fasterxml.jackson.core.JsonFactory` and    `org.apache.flink.shaded.jackson2.com.fasterxml.jackson.core.ObjectCodec`
      * the contents of these files should also be relocated
    * wait for travis end-to-end tests to verify general functionality
    ## Does this pull request potentially affect one of the following parts:
      - Dependencies (does it add or upgrade a dependency): (yes)
      - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
      - The serializers: (no)
      - The runtime per-record code paths (performance sensitive): (no)
      - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing,
Yarn/Mesos, ZooKeeper: (no)
      - The S3 file system connector: (no)
    ## Documentation
      - Does this pull request introduce a new feature? (no)
      - If yes, how is the feature documented? (not applicable)

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/zentol/flink 8110

Alternatively you can review and apply these changes as the patch at:


To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #5037
commit 904f29583bc478a012f5fa818b388afc11c9ebbe
Author: zentol <chesnay@apache.org>
Date:   2017-11-20T12:58:21Z

    [FLINK-8110][dist] Relocate jackson services in flink-dist


> fasterxml jackson services are not relocated
> --------------------------------------------
>                 Key: FLINK-8110
>                 URL: https://issues.apache.org/jira/browse/FLINK-8110
>             Project: Flink
>          Issue Type: Task
>          Components: Build System
>    Affects Versions: 1.4.0
>            Reporter: Chesnay Schepler
>            Assignee: Chesnay Schepler
>            Priority: Blocker
>             Fix For: 1.4.0
> The jackson services aren't properly relocated. Flink-shaded uses maven-shade-plugin:2.4.1
which doesn't properly relocate services as described in the flink-s3-fs-presto shade-plugin

This message was sent by Atlassian JIRA

View raw message