flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-8081) Annotate MetricRegistry#getReporters() with @VisibleForTesting
Date Mon, 27 Nov 2017 12:02:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-8081?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16266699#comment-16266699
] 

ASF GitHub Bot commented on FLINK-8081:
---------------------------------------

Github user asfgit closed the pull request at:

    https://github.com/apache/flink/pull/5049


> Annotate MetricRegistry#getReporters() with @VisibleForTesting
> --------------------------------------------------------------
>
>                 Key: FLINK-8081
>                 URL: https://issues.apache.org/jira/browse/FLINK-8081
>             Project: Flink
>          Issue Type: Improvement
>          Components: Metrics, Tests
>    Affects Versions: 1.4.0
>            Reporter: Chesnay Schepler
>            Assignee: Chesnay Schepler
>             Fix For: 1.5.0, 1.4.1
>
>
> {{MetricRegistry#getReporters()}} is only used for testing purposes to provide access
to instantiated reporters. We should annotate this method with {{@VisibleForTesting}}.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message