flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-8081) Annotate MetricRegistry#getReporters() with @VisibleForTesting
Date Wed, 22 Nov 2017 11:06:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-8081?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16262296#comment-16262296
] 

ASF GitHub Bot commented on FLINK-8081:
---------------------------------------

GitHub user zentol opened a pull request:

    https://github.com/apache/flink/pull/5049

    [FLINK-8081][metrics] Annotate 'MetricRegistry#getReporters' with '@V…

    ## What is the purpose of the change
    
    `MetricRegistry#getReporters()` is only used for testing purposes to provide access to
instantiated reporters. We should annotate this method with `@VisibleForTesting`.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/zentol/flink 8081

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/5049.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #5049
    
----
commit 18576da06905c4401bf701e0c09ee4fb44de2ec7
Author: zentol <chesnay@apache.org>
Date:   2017-11-15T12:14:18Z

    [FLINK-8081][metrics] Annotate 'MetricRegistry#getReporters' with '@VisibleForTesting'

----


> Annotate MetricRegistry#getReporters() with @VisibleForTesting
> --------------------------------------------------------------
>
>                 Key: FLINK-8081
>                 URL: https://issues.apache.org/jira/browse/FLINK-8081
>             Project: Flink
>          Issue Type: Improvement
>          Components: Metrics, Tests
>    Affects Versions: 1.4.0
>            Reporter: Chesnay Schepler
>            Assignee: Chesnay Schepler
>
> {{MetricRegistry#getReporters()}} is only used for testing purposes to provide access
to instantiated reporters. We should annotate this method with {{@VisibleForTesting}}.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message