flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-8069) Support empty watermark strategy for TableSources
Date Wed, 15 Nov 2017 11:29:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-8069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16253314#comment-16253314
] 

ASF GitHub Bot commented on FLINK-8069:
---------------------------------------

Github user fhueske commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5016#discussion_r151096958
  
    --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/sources/definedTimeAttributes.scala
---
    @@ -62,12 +62,13 @@ trait DefinedRowtimeAttributes {
       *
       * @param attributeName The name of the rowtime attribute.
       * @param timestampExtractor The timestamp extractor to derive the values of the attribute.
    -  * @param watermarkStrategy The watermark strategy associated with the attribute.
    +  * @param watermarkStrategy The watermark strategy associated with the attribute. With
the default
    --- End diff --
    
    revert changes in this class


> Support empty watermark strategy for TableSources
> -------------------------------------------------
>
>                 Key: FLINK-8069
>                 URL: https://issues.apache.org/jira/browse/FLINK-8069
>             Project: Flink
>          Issue Type: Improvement
>          Components: Table API & SQL
>            Reporter: Timo Walther
>            Assignee: Xingcan Cui
>
> In case the underlying data stream source emits watermarks, it should be possible to
define an empty watermark strategy for rowtime attributes in the {{RowtimeAttributeDescriptor}}.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message