flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-8025) Let DashboardConfigHandler extend from AbstractRestHandler
Date Wed, 08 Nov 2017 13:47:01 GMT

    [ https://issues.apache.org/jira/browse/FLINK-8025?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16243954#comment-16243954
] 

ASF GitHub Bot commented on FLINK-8025:
---------------------------------------

GitHub user tillrohrmann opened a pull request:

    https://github.com/apache/flink/pull/4983

    [FLINK-8025] Let DashboardConfigHandler directly extend AbstractRestHandler

    ## What is the purpose of the change
    
    Let DashboardConfigHandler directly extend AbstractRestHandler.
    
    ## Verifying this change
    
    This change is a trivial rework / code cleanup without any test coverage.
    
    ## Does this pull request potentially affect one of the following parts:
    
      - Dependencies (does it add or upgrade a dependency): (no)
      - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
      - The serializers: (no)
      - The runtime per-record code paths (performance sensitive): (no)
      - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing,
Yarn/Mesos, ZooKeeper: (no)
      - The S3 file system connector: (no)
    
    ## Documentation
    
      - Does this pull request introduce a new feature? (no)
      - If yes, how is the feature documented? (not applicable)


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/tillrohrmann/flink generalizedDashboardConfigHandler

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/4983.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #4983
    
----
commit 18d8d1af433715a24c2d2e354d8dcf2efb30c49d
Author: Till Rohrmann <trohrmann@apache.org>
Date:   2017-11-04T13:56:11Z

    [FLINK-8000] Sort Rest handler URLS in RestServerEndpoint
    
    Introduce special RestHandlerUrlComparator to sort REST URLs such that
    URLs with path parameters are sorted after those without or fewer.
    
    E.g. the following order would be established
    
    /jobs
    /jobs/overview
    /jobs/:jobid
    /jobs/:jobid/config
    /:*

commit bdc5d0eaf803475eb9fc550be3ab59cd176c2894
Author: Till Rohrmann <trohrmann@apache.org>
Date:   2017-11-06T17:48:53Z

    [FLINK-8024] Let ClusterOverviewHandler directly extend from AbstractRestHandler

commit 2ddfa4e57b03fa3e42d60ae8da7b4bbc6b24e777
Author: Till Rohrmann <trohrmann@apache.org>
Date:   2017-11-06T17:56:01Z

    [FLINK-8025] Let DashboardConfigHandler directly extend AbstractRestHandler

----


> Let DashboardConfigHandler extend from AbstractRestHandler
> ----------------------------------------------------------
>
>                 Key: FLINK-8025
>                 URL: https://issues.apache.org/jira/browse/FLINK-8025
>             Project: Flink
>          Issue Type: Sub-task
>          Components: REST
>    Affects Versions: 1.5.0
>            Reporter: Till Rohrmann
>            Assignee: Till Rohrmann
>            Priority: Minor
>              Labels: flip-6
>             Fix For: 1.5.0
>
>
> The {{DashboardConfigHandler}} should directly extend {{AbstractRestHandler}} to get
rid of the {{LegacyRestHandler}}.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message