flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Keren Zhu (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-7998) Make case classes in TPCHQuery3.java public to allow dynamic instantiation
Date Tue, 07 Nov 2017 12:19:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-7998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16241918#comment-16241918

Keren Zhu commented on FLINK-7998:

[~Zentol] Yes it's straight-up not working. It triggers an IllegalAccessException when running.
The scala equivalent is fine, because these three case classes are by default public. 

There are also some stupid typos in this file. As you can see _custom_ and _orders_ are messed
up below.
/* TPCHQuery3.java L103 */
DataSet<Lineitem> lineitems = getLineitemDataSet(env, params.get("lineitem"));
DataSet<Order> orders = getOrdersDataSet(env, params.get("customer"));  /* TYPO! */
DataSet<Customer> customers = getCustomerDataSet(env, params.get("orders"));

> Make case classes in TPCHQuery3.java public to allow dynamic instantiation
> --------------------------------------------------------------------------
>                 Key: FLINK-7998
>                 URL: https://issues.apache.org/jira/browse/FLINK-7998
>             Project: Flink
>          Issue Type: Bug
>          Components: Examples
>    Affects Versions: 1.3.2
>            Reporter: Keren Zhu
>            Priority: Minor
>              Labels: easyfix
>   Original Estimate: 5m
>  Remaining Estimate: 5m
> Case classes Lineitem, Customer and Order in example TPCHQuery3.java are set to private.
This causes an IllegalAccessException exception because of reflection check in dynamic class
instantiation. Making them public resolves the problem (which is what implicitly suggested
by _case class_ in TPCHQuery3.scala)

This message was sent by Atlassian JIRA

View raw message