flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-7992) extend PR template with S3 question
Date Mon, 06 Nov 2017 12:52:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-7992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16240232#comment-16240232
] 

ASF GitHub Bot commented on FLINK-7992:
---------------------------------------

Github user NicoK commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4952#discussion_r149070730
  
    --- Diff: .github/PULL_REQUEST_TEMPLATE.md ---
    @@ -63,9 +63,9 @@ This change added tests and can be verified as follows:
       - The serializers: (yes / no / don't know)
       - The runtime per-record code paths (performance sensitive): (yes / no / don't know)
       - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing,
Yarn/Mesos, ZooKeeper: (yes / no / don't know)
    +  - The S3 file system connector: (yes / no / don't know)
    --- End diff --
    
    Wouldn't this be true for any of the points we ask users to fill out? In the end, there
should probably be a committer's guide (is there?) with more details on everything but for
the committer only - we don't want to scare the contributer away. 


> extend PR template with S3 question
> -----------------------------------
>
>                 Key: FLINK-7992
>                 URL: https://issues.apache.org/jira/browse/FLINK-7992
>             Project: Flink
>          Issue Type: Improvement
>          Components: Documentation
>            Reporter: Nico Kruber
>            Assignee: Nico Kruber
>             Fix For: 1.4.0
>
>
> S3 file system tests are only run if AWS credentials are specified, i.e. {{ARTIFACTS_AWS_BUCKET}},
{{ARTIFACTS_AWS_ACCESS_KEY}}, and {{ARTIFACTS_AWS_SECRET_KEY}}. Since these must remain secret,
they are only set in Apache Flink's Travis CI configuration and not available in the Travis
runs on pull requests (PR) to not leak them in any way. This however means that if a contributor
changes something S3-related, the PR's test results will not reflect the actual changes and
if something breaks there, we will only see it once merged.
> Therefore, I propose to add one more question to the PR template so that the committer
is aware of this fact and the need to run the tests in his own Travis CI configuration first
with proper AWS credentials set up.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message