flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-7960) ExecutionGraphRestartTest fails sporadically
Date Wed, 01 Nov 2017 22:15:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-7960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16234840#comment-16234840
] 

ASF GitHub Bot commented on FLINK-7960:
---------------------------------------

Github user tillrohrmann commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4933#discussion_r148399427
  
    --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/Execution.java
---
    @@ -844,7 +844,7 @@ else if (current == CANCELING || current == RUNNING || current ==
DEPLOYING) {
     				// failing in the meantime may happen and is no problem.
     				// anything else is a serious problem !!!
     				if (current != FAILED) {
    -					String message = String.format("Asynchronous race: Found state %s after successful
cancel call.", state);
    +					String message = String.format("Asynchronous race: Found %s in state %s after successful
cancel call.", vertex.getTaskNameWithSubtaskIndex(), state);
     					LOG.error(message);
    --- End diff --
    
    Not really, because we reuse the message in the line below. Moreover, the logging statement
is error and thus, will be evaluated in almost all cases. What one could argue is whether
normal string concatenation wouldn't be faster than `String.format`.


> ExecutionGraphRestartTest fails sporadically
> --------------------------------------------
>
>                 Key: FLINK-7960
>                 URL: https://issues.apache.org/jira/browse/FLINK-7960
>             Project: Flink
>          Issue Type: Bug
>          Components: Distributed Coordination, Tests
>    Affects Versions: 1.4.0, 1.3.2
>            Reporter: Gary Yao
>            Assignee: Till Rohrmann
>            Priority: Critical
>              Labels: test-stability
>             Fix For: 1.4.0
>
>
> When running {{ExecutionGraphRestartTest}} as a whole, {{testConcurrentLocalFailAndRestart}}
fails sporadically.
> *How to reproduce*
> Run
> {noformat}
> mvn -DfailIfNoTests=false -Dtest=ExecutionGraphRestartTest test
> {noformat}
> Stacktrace:
> {noformat}
> java.lang.AssertionError
> 	at org.apache.flink.runtime.executiongraph.ExecutionGraphTestUtils.switchToRunning(ExecutionGraphTestUtils.java:205)
> 	at org.apache.flink.runtime.executiongraph.ExecutionGraphRestartTest.testConcurrentLocalFailAndRestart(ExecutionGraphRestartTest.java:657)
> 	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> 	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> 	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> 	at java.lang.reflect.Method.invoke(Method.java:498)
> 	at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
> 	at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
> 	at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
> 	at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
> 	at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
> 	at org.junit.rules.TestWatcher$1.evaluate(TestWatcher.java:55)
> 	at org.junit.rules.RunRules.evaluate(RunRules.java:20)
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message