flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-7907) Flink Metrics documentation missing Scala examples
Date Wed, 29 Nov 2017 16:29:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-7907?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16271042#comment-16271042
] 

ASF GitHub Bot commented on FLINK-7907:
---------------------------------------

Github user zentol commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5071#discussion_r153838811
  
    --- Diff: docs/monitoring/metrics.md ---
    @@ -61,9 +63,35 @@ public class MyMapper extends RichMapFunction<String, String>
{
     }
     
     {% endhighlight %}
    +</div>
    +
    +<div data-lang="scala" markdown="1">
    +{% highlight scala %}
    +
    +public class MyMapper extends RichMapFunction[String,String] {
    --- End diff --
    
    remove public keyword (also applies to remaining examples)


> Flink Metrics documentation missing Scala examples
> --------------------------------------------------
>
>                 Key: FLINK-7907
>                 URL: https://issues.apache.org/jira/browse/FLINK-7907
>             Project: Flink
>          Issue Type: Improvement
>          Components: Documentation
>            Reporter: Colin Williams
>            Assignee: Hai Zhou UTC+8
>            Priority: Minor
>
> The Flink metrics documentation is missing Scala examples for many of the metrics types.
To be consistent there should be Scala examples for all the types.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message