flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-7880) flink-queryable-state-java fails with core-dump
Date Wed, 29 Nov 2017 14:42:05 GMT

    [ https://issues.apache.org/jira/browse/FLINK-7880?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16270839#comment-16270839
] 

ASF GitHub Bot commented on FLINK-7880:
---------------------------------------

Github user zentol commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5062#discussion_r153798768
  
    --- Diff: flink-queryable-state/flink-queryable-state-client-java/src/main/java/org/apache/flink/queryablestate/network/Client.java
---
    @@ -166,28 +167,57 @@ public String getClientName() {
     	 * Shuts down the client and closes all connections.
     	 *
     	 * <p>After a call to this method, all returned futures will be failed.
    +	 *
    +	 * @return A {@link CompletableFuture} that will be completed when the shutdown process
is done.
     	 */
    -	public void shutdown() {
    -		if (shutDown.compareAndSet(false, true)) {
    +	public CompletableFuture<Void> shutdown() {
    +		final CompletableFuture<Void> newShutdownFuture = new CompletableFuture<>();
    --- End diff --
    
    calling shutdown twice in a row will result in a future being returned that never completes.


> flink-queryable-state-java fails with core-dump
> -----------------------------------------------
>
>                 Key: FLINK-7880
>                 URL: https://issues.apache.org/jira/browse/FLINK-7880
>             Project: Flink
>          Issue Type: Bug
>          Components: Queryable State, Tests
>    Affects Versions: 1.4.0
>            Reporter: Till Rohrmann
>            Assignee: Kostas Kloudas
>            Priority: Critical
>              Labels: test-stability
>
> The {{flink-queryable-state-java}} module fails on Travis with a core dump.
> https://travis-ci.org/tillrohrmann/flink/jobs/289949829



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message