flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-7876) Register TaskManagerMetricGroup under ResourceID instead of InstanceID
Date Wed, 01 Nov 2017 10:29:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-7876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16233895#comment-16233895
] 

ASF GitHub Bot commented on FLINK-7876:
---------------------------------------

Github user tillrohrmann commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4872#discussion_r148226096
  
    --- Diff: flink-mesos/src/main/scala/org/apache/flink/mesos/runtime/clusterframework/MesosJobManager.scala
---
    @@ -31,7 +31,8 @@ import org.apache.flink.runtime.instance.InstanceManager
     import org.apache.flink.runtime.jobmanager.SubmittedJobGraphStore
     import org.apache.flink.runtime.jobmanager.scheduler.{Scheduler => FlinkScheduler}
     import org.apache.flink.runtime.leaderelection.LeaderElectionService
    -import org.apache.flink.runtime.metrics.{MetricRegistry => FlinkMetricRegistry}
    +import org.apache.flink.runtime.metrics.groups.JobManagerMetricGroup
    +import org.apache.flink.runtime.metrics.{MetricRegistryImpl => FlinkMetricRegistry}
    --- End diff --
    
    Will remove it.


> Register TaskManagerMetricGroup under ResourceID instead of InstanceID
> ----------------------------------------------------------------------
>
>                 Key: FLINK-7876
>                 URL: https://issues.apache.org/jira/browse/FLINK-7876
>             Project: Flink
>          Issue Type: Improvement
>          Components: Metrics
>    Affects Versions: 1.4.0
>            Reporter: Till Rohrmann
>            Assignee: Till Rohrmann
>            Priority: Minor
>              Labels: flip-6
>
> Currently, the {{TaskManager}} registers the {{TaskManagerMetricGroup}} under its {{InstanceID}}
and thereby binding its metrics effectively to the lifetime of its registration with the {{JobManager}}.
This has also implications how the REST handler retrieve the TaskManager metrics, namely by
its {{InstanceID}}.
> I would actually propose to register the {{TaskManagerMetricGroup}} under the {{TaskManager}}/{{TaskExecutor}}
{{ResourceID}} which is valid over the whole lifetime of the {{TaskManager}}/{{TaskExecutor}}.
That way we would also be able to query metrics independent of the connection status to the
{{JobManager}}.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message