flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-7748) remove event listener behaviour from ResultPartitionWriter
Date Thu, 30 Nov 2017 09:52:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-7748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16272449#comment-16272449
] 

ASF GitHub Bot commented on FLINK-7748:
---------------------------------------

Github user pnowojski commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4761#discussion_r154023066
  
    --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/api/writer/ResultPartitionWriter.java
---
    @@ -34,12 +31,10 @@
      * The {@link ResultPartitionWriter} is the runtime API for producing results. It
      * supports two kinds of data to be sent: buffers and events.
      */
    -public class ResultPartitionWriter implements EventListener<TaskEvent> {
    --- End diff --
    
    I do not understand why this class was previously implementing `EventListener`. I couldn't
find any context in which it was used that way.


> remove event listener behaviour from ResultPartitionWriter
> ----------------------------------------------------------
>
>                 Key: FLINK-7748
>                 URL: https://issues.apache.org/jira/browse/FLINK-7748
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Network
>    Affects Versions: 1.4.0
>            Reporter: Nico Kruber
>            Assignee: Nico Kruber
>
> {{ResultPartitionWriter}} currently implements the {{EventListener}} interface and is
used for event registration, although event publishing is already handled via the {{TaskEventDispatcher}}.
This should be unified by using {{TaskEventDispatcher}} only.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message