flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-7716) Port JobManagerMetricsHandler to new REST endpoint
Date Mon, 27 Nov 2017 13:27:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-7716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16266800#comment-16266800

ASF GitHub Bot commented on FLINK-7716:

GitHub user GJL opened a pull request:


    [FLINK-7716][flip6] Migrate JobManagerMetricsHandler to new RestServerEndpoint

    ## What is the purpose of the change
    *FLIP-6 efforts: Migrating HTTP handlers*
    ## Brief change log
      - Migrate logic from `org.apache.flink.runtime.rest.handler.legacy.metrics.JobManagerMetricsHandler
to` new handler.
      - Add new handler to `DispatcherRestEndpoint`.
    ## Verifying this change
      - *Added unit tests for all new classes and modified existing classes except for DispatcherRestEndpoint.*
      - *Manually deployed a job locally and verified with `curl` that JobManager metrics
can be queried in FLIP-6 standalone mode.*
    ## Does this pull request potentially affect one of the following parts:
      - Dependencies (does it add or upgrade a dependency): (yes / **no**)
      - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes
/ **no**)
      - The serializers: (yes / **no** / don't know)
      - The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
      - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing,
Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)
      - The S3 file system connector: (yes / **no** / don't know)
    ## Documentation
      - Does this pull request introduce a new feature? (yes / **no**)
      - If yes, how is the feature documented? (**not applicable** / docs / JavaDocs / not
    CC: @tillrohrmann 

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/GJL/flink FLINK-7716

Alternatively you can review and apply these changes as the patch at:


To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #5083
commit 17244d63fcc1610c83a5c020a63fe045087a2f07
Author: gyao <gary@data-artisans.com>
Date:   2017-11-27T13:18:48Z

    [FLIP-7716][flip6] Migrate JobManagerMetricsHandler to new RestServerEndpoint
    Migrate logic in
    to new handler and add new handler to DispatcherRestEndpoint.

commit 51d37ccce04b912dcda6f5ae74d8092d22b5ff9d
Author: gyao <gary@data-artisans.com>
Date:   2017-11-27T13:22:17Z

    [FLINK-7716][Javadoc] Deprecate method MetricStore#getJobManager().
    There is a semantically equivalent method in MetricStore.

commit c7283194b19719270e4c0c2cc185876e710b750a
Author: gyao <gary@data-artisans.com>
Date:   2017-11-27T13:24:42Z

    [hotfix][Javadoc] Fix typo in ConversionException


> Port JobManagerMetricsHandler to new REST endpoint
> --------------------------------------------------
>                 Key: FLINK-7716
>                 URL: https://issues.apache.org/jira/browse/FLINK-7716
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Distributed Coordination, REST, Webfrontend
>            Reporter: Tzu-Li (Gordon) Tai
>            Assignee: Gary Yao
>              Labels: flip-6
>             Fix For: 1.5.0
> Port {{JobManagerMetricsHandler}} to new REST endpoint.

This message was sent by Atlassian JIRA

View raw message