flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-7499) double buffer release in SpillableSubpartitionView
Date Thu, 23 Nov 2017 16:57:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-7499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16264593#comment-16264593
] 

ASF GitHub Bot commented on FLINK-7499:
---------------------------------------

Github user NicoK commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4581#discussion_r152845922
  
    --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/io/network/partition/ResultPartitionTest.java
---
    @@ -145,6 +165,45 @@ protected void testAddOnReleasedPartition(final ResultPartitionType
pipelined)
     		}
     	}
     
    +	@Test
    +	public void testAddOnPipelinedPartition() throws Exception {
    +		testAddOnPartition(ResultPartitionType.PIPELINED);
    +	}
    +
    +	@Test
    +	public void testAddOnBlockingPartition() throws Exception {
    +		testAddOnPartition(ResultPartitionType.BLOCKING);
    +	}
    +
    +	/**
    +	 * Tests {@link ResultPartition#add} on a working partition.
    +	 *
    +	 * @param pipelined the result partition type to set up
    +	 */
    +	protected void testAddOnPartition(final ResultPartitionType pipelined)
    +		throws Exception {
    +		ResultPartitionConsumableNotifier notifier = mock(ResultPartitionConsumableNotifier.class);
    --- End diff --
    
    do you think it's better to have a real implementation of that interface, spy on it, and
then verify the expected method calls? - this actually seems like some more overhead with
little/no gain. I'd prefer to leave it as is for now.


> double buffer release in SpillableSubpartitionView
> --------------------------------------------------
>
>                 Key: FLINK-7499
>                 URL: https://issues.apache.org/jira/browse/FLINK-7499
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Network
>    Affects Versions: 1.2.0, 1.1.4, 1.3.0, 1.1.5, 1.2.1, 1.2.2, 1.3.1, 1.4.0, 1.3.2, 1.3.3
>            Reporter: Nico Kruber
>            Assignee: Nico Kruber
>            Priority: Blocker
>
> {{SpillableSubpartitionView#releaseMemory()}} recycles its buffers twice: once asynchronously
after the write operation and once in {{SpillableSubpartitionView#releaseMemory()}} after
adding the write operation to the queue.
> 1) if {{SpillableSubpartitionView#releaseMemory()}} hits first and the buffer is recycled,
the memory region may already be reused despite the pending write
> 2) If, for some reason (probably only in tests like {{SpillableSubpartitionTest#testConsumeSpillablePartitionSpilledDuringConsume()}}?),
the buffer is retained and to be used in parallel somewhere else it may also not be available
anymore or contain corrupt data.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message