flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-7419) Shade jackson dependency in flink-avro
Date Thu, 09 Nov 2017 16:51:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-7419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16246007#comment-16246007
] 

ASF GitHub Bot commented on FLINK-7419:
---------------------------------------

Github user StephanEwen commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4981#discussion_r150020494
  
    --- Diff: flink-formats/flink-avro/pom.xml ---
    @@ -185,17 +185,6 @@ under the License.
     						<configuration combine.self="override">
     							<dependencyReducedPomLocation>${project.basedir}/target/dependency-reduced-pom.xml</dependencyReducedPomLocation>
     							<promoteTransitiveDependencies>true</promoteTransitiveDependencies>
    --- End diff --
    
    We can probably remove the complete shading entry in that pom. Seem not to do anything
anyways. Promoting transitive dependencies when nothing except `force-shading` is shaded into
the jar should be a no-op. (theoretically, one never knows with the shade plugin ;-) )


> Shade jackson dependency in flink-avro
> --------------------------------------
>
>                 Key: FLINK-7419
>                 URL: https://issues.apache.org/jira/browse/FLINK-7419
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Build System
>            Reporter: Stephan Ewen
>            Assignee: Chesnay Schepler
>            Priority: Blocker
>             Fix For: 1.4.0
>
>
> Avro uses {{org.codehouse.jackson}} which also exists in multiple incompatible versions.
We should shade it to {{org.apache.flink.shaded.avro.org.codehouse.jackson}}.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message