flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-7416) Implement Netty receiver outgoing pipeline for credit-based
Date Thu, 30 Nov 2017 08:25:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-7416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16272320#comment-16272320
] 

ASF GitHub Bot commented on FLINK-7416:
---------------------------------------

Github user zhijiangW commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4533#discussion_r154009420
  
    --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/netty/NettyMessage.java
---
    @@ -584,4 +587,60 @@ static CloseRequest readFrom(@SuppressWarnings("unused") ByteBuf
buffer) throws
     			return new CloseRequest();
     		}
     	}
    +
    +	static class AddCredit extends NettyMessage {
    +
    +		private static final byte ID = 6;
    +
    +		final ResultPartitionID partitionId;
    +
    +		final int credit;
    +
    +		final InputChannelID receiverId;
    +
    +		AddCredit(ResultPartitionID partitionId, int credit, InputChannelID receiverId) {
    +			this.partitionId = partitionId;
    +			this.credit = credit;
    --- End diff --
    
    I think it should be `checkArgument(credit > 0)`?
    I will add this check in `AddCredit` here and the `PartitionRequest` will be added in
the last PR to avoid temporary value 0, what do you think?


> Implement Netty receiver outgoing pipeline for credit-based
> -----------------------------------------------------------
>
>                 Key: FLINK-7416
>                 URL: https://issues.apache.org/jira/browse/FLINK-7416
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Network
>            Reporter: zhijiang
>            Assignee: zhijiang
>             Fix For: 1.5.0
>
>
> This is a part of work for credit-based network flow control.
> The related works are :
> *  We define a new message called {{AddCredit}} to notify the incremental credit during
data shuffle. 
> * Whenever an {{InputChannel}}’s unannounced credit goes up from zero, the channel
is enqueued in the pipeline.
> * Whenever the channel becomes writable, it takes the next {{InputChannel}} and sends
its unannounced credit. The credit is reset to zero after each sent.
> * That way, messages are sent as often as the network has capacity and contain as much
credit as available for the channel at that point in time. Otherwise, it would only add latency
to the announcements and not increase throughput.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message