flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-4812) Report Watermark metrics in all operators
Date Wed, 29 Nov 2017 10:02:01 GMT

    [ https://issues.apache.org/jira/browse/FLINK-4812?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16270519#comment-16270519
] 

ASF GitHub Bot commented on FLINK-4812:
---------------------------------------

Github user tzulitai commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5092#discussion_r153734546
  
    --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/StreamSourceContexts.java
---
    @@ -313,6 +325,7 @@ protected void processAndCollectWithTimestamp(T element, long timestamp)
{
     		@Override
     		protected void processAndEmitWatermark(Watermark mark) {
     			output.emitWatermark(mark);
    +			watermarkGauge.setCurrentLowWatermark(mark.getTimestamp());
    --- End diff --
    
    Should probably move this to the base abstract class `WatermarkContext`, after `processAndEmitWatermark(mark)`
in the `emitWatermark` method (line):
    https://github.com/apache/flink/pull/5092/files#diff-e38689efd0a97938646aa97eb8a97d96R438
    
    The `processAndEmitWatermark` method of `AutomaticWatermarkContext` should actually also
update the watermark metric after emitting the `Long.MAX_VALUE` watermark, but currently doesn't:
    https://github.com/apache/flink/pull/5092/files#diff-e38689efd0a97938646aa97eb8a97d96R215
    
    Implementing the metric update in the base class should cover both cases.


> Report Watermark metrics in all operators
> -----------------------------------------
>
>                 Key: FLINK-4812
>                 URL: https://issues.apache.org/jira/browse/FLINK-4812
>             Project: Flink
>          Issue Type: Improvement
>          Components: Metrics
>            Reporter: Robert Metzger
>            Assignee: Chesnay Schepler
>            Priority: Critical
>             Fix For: 1.5.0
>
>
> As reported by a user, Flink does currently not export the current low watermark for
sources (http://apache-flink-mailing-list-archive.1008284.n3.nabble.com/currentLowWatermark-metric-not-reported-for-all-tasks-td13770.html).
> This JIRA is for adding such a metric for the sources as well.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message