flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From NicoK <...@git.apache.org>
Subject [GitHub] flink pull request #4533: [FLINK-7416][network] Implement Netty receiver out...
Date Thu, 30 Nov 2017 09:49:21 GMT
Github user NicoK commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4533#discussion_r154027406
  
    --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/RemoteInputChannel.java
---
    @@ -283,10 +283,13 @@ public String toString() {
     	// ------------------------------------------------------------------------
     
     	/**
    -	 * Enqueue this input channel in the pipeline for sending unannounced credits to producer.
    +	 * Enqueue this input channel in the pipeline for notifying the producer of unannounced
credit.
     	 */
     	void notifyCreditAvailable() {
    -		//TODO in next PR
    +		// We should skip the notification if this channel is already released.
    +		if (!isReleased.get() && partitionRequestClient != null) {
    --- End diff --
    
    If we set it to `null` concurrently, we may need some more synchronisation here, so I'd
leave that logic as it is for now.


---

Mime
View raw message