flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From zentol <...@git.apache.org>
Subject [GitHub] flink pull request #5062: [FLINK-7880][QS] Wait for proper resource cleanup ...
Date Wed, 29 Nov 2017 14:41:08 GMT
Github user zentol commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5062#discussion_r153793887
  
    --- Diff: flink-queryable-state/flink-queryable-state-runtime/src/test/java/org/apache/flink/queryablestate/itcases/HAAbstractQueryableStateTestBase.java
---
    @@ -80,19 +80,18 @@ public static void setup(int proxyPortRangeStart, int serverPortRangeStart)
{
     
     	@AfterClass
     	public static void tearDown() {
    -		if (cluster != null) {
    +		try {
    +			client.shutdownAndWait();
    +
     			cluster.stop();
     			cluster.awaitTermination();
    -		}
     
    -		try {
     			zkServer.stop();
     			zkServer.close();
    -		} catch (Exception e) {
    +
    +		} catch (Throwable e) {
    --- End diff --
    
    try-catch block is unnecessary


---

Mime
View raw message