flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From zentol <...@git.apache.org>
Subject [GitHub] flink pull request #5062: [FLINK-7880][QS] Wait for proper resource cleanup ...
Date Wed, 29 Nov 2017 14:41:05 GMT
Github user zentol commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5062#discussion_r153794621
  
    --- Diff: flink-queryable-state/flink-queryable-state-client-java/src/main/java/org/apache/flink/queryablestate/client/QueryableStateClient.java
---
    @@ -108,9 +108,33 @@ public QueryableStateClient(final InetAddress remoteAddress, final
int remotePor
     				new DisabledKvStateRequestStats());
     	}
     
    -	/** Shuts down the client. */
    -	public void shutdown() {
    -		client.shutdown();
    +	/**
    +	 * Shuts down the client and returns a {@link CompletableFuture} that
    +	 * will be completed when the shutdown process is completed.
    +	 *
    +	 * <p>If an exception is thrown for any reason, then the returned future
    +	 * will be completed exceptionally with that exception.
    +	 *
    +	 * @return A {@link CompletableFuture} for further handling of the
    +	 * shutdown result.
    +	 */
    +	public CompletableFuture<?> shutdownAndHandle() {
    +		return client.shutdown();
    +	}
    +
    +	/**
    +	 * Shuts down the client and waits until shutdown is completed.
    +	 *
    +	 * <p>If an exception is thrown, a warning is printed containing
    --- End diff --
    
    the warning is logged, not printed (generally implies stdout).


---

Mime
View raw message