flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From NicoK <...@git.apache.org>
Subject [GitHub] flink pull request #4533: [FLINK-7416][network] Implement Netty receiver out...
Date Tue, 28 Nov 2017 11:24:06 GMT
Github user NicoK commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4533#discussion_r153456278
  
    --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/RemoteInputChannel.java
---
    @@ -230,7 +230,7 @@ void notifySubpartitionConsumed() {
     	 * Releases all exclusive and floating buffers, closes the partition request client.
     	 */
     	@Override
    -	void releaseAllResources() throws IOException {
    +	public void releaseAllResources() throws IOException {
    --- End diff --
    
    actually, `package-private` is enough here after the suggested changes in the tests below
(or, if needed, mark `@VisibleForTesting`)


---

Mime
View raw message