flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Aegeaner <...@git.apache.org>
Subject [GitHub] flink issue #5065: [FLINK-8139][table] Check for proper equals() and hashCod...
Date Sat, 25 Nov 2017 13:04:49 GMT
Github user Aegeaner commented on the issue:

    https://github.com/apache/flink/pull/5065
  
    Hi @fhueske , thanks for review. 
    I will update` equals() `and `hashcode() `methods of Row, but I also noticed that in `JoinOperator`
and `KeySelector`, they used `RowComparator` to compare row elements. 
    For the unit test, I noticed in `TypeInformationTestBase` there is a` testHashcodeAndEquals`
method already, I will complete this test to add test case with type info without implementing
its own `hashcode ` and `equals` method.


---

Mime
View raw message