flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From pnowojski <...@git.apache.org>
Subject [GitHub] flink pull request #4559: [FLINK-7468][network] Implement sender backlog log...
Date Mon, 20 Nov 2017 14:51:53 GMT
Github user pnowojski commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4559#discussion_r152008483
  
    --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/SpillableSubpartition.java
---
    @@ -246,9 +246,9 @@ public int unsynchronizedGetNumberOfQueuedBuffers() {
     	@Override
     	public String toString() {
     		return String.format("SpillableSubpartition [%d number of buffers (%d bytes)," +
    -						"finished? %s, read view? %s, spilled? %s]",
    -				getTotalNumberOfBuffers(), getTotalNumberOfBytes(), isFinished, readView != null,
    -				spillWriter != null);
    +				"%d backlog, finished? %s, read view? %s, spilled? %s]",
    --- End diff --
    
    `"%d buffers in backlog, finished (...)"` ? 
    `"backlog = %d, finished (...)"` ? 
    `"%d in backlog, finished (...)"` ? 
    
    `%d backlog` is a little bit cryptic.


---

Mime
View raw message