flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From zhijiangW <...@git.apache.org>
Subject [GitHub] flink pull request #4533: [FLINK-7416][network] Implement Netty receiver out...
Date Mon, 20 Nov 2017 09:17:52 GMT
Github user zhijiangW commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4533#discussion_r151935549
  
    --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/netty/CreditBasedClientHandler.java
---
    @@ -0,0 +1,364 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.flink.runtime.io.network.netty;
    +
    +import org.apache.flink.core.memory.MemorySegment;
    +import org.apache.flink.core.memory.MemorySegmentFactory;
    +import org.apache.flink.runtime.io.network.buffer.Buffer;
    +import org.apache.flink.runtime.io.network.buffer.FreeingBufferRecycler;
    +import org.apache.flink.runtime.io.network.netty.exception.LocalTransportException;
    +import org.apache.flink.runtime.io.network.netty.exception.RemoteTransportException;
    +import org.apache.flink.runtime.io.network.netty.exception.TransportException;
    +import org.apache.flink.runtime.io.network.netty.NettyMessage.AddCredit;
    +import org.apache.flink.runtime.io.network.partition.PartitionNotFoundException;
    +import org.apache.flink.runtime.io.network.partition.consumer.InputChannelID;
    +import org.apache.flink.runtime.io.network.partition.consumer.RemoteInputChannel;
    +
    +import org.apache.flink.shaded.netty4.io.netty.channel.Channel;
    +import org.apache.flink.shaded.netty4.io.netty.channel.ChannelFuture;
    +import org.apache.flink.shaded.netty4.io.netty.channel.ChannelFutureListener;
    +import org.apache.flink.shaded.netty4.io.netty.channel.ChannelHandlerContext;
    +import org.apache.flink.shaded.netty4.io.netty.channel.ChannelInboundHandlerAdapter;
    +
    +import org.slf4j.Logger;
    +import org.slf4j.LoggerFactory;
    +
    +import java.io.IOException;
    +import java.net.SocketAddress;
    +import java.util.ArrayDeque;
    +import java.util.concurrent.ConcurrentHashMap;
    +import java.util.concurrent.ConcurrentMap;
    +import java.util.concurrent.atomic.AtomicReference;
    +
    +/**
    + * Channel handler to read the messages of buffer response or error response from the
    + * producer, to write and flush the unannounced credits for the producer.
    + */
    +class CreditBasedClientHandler extends ChannelInboundHandlerAdapter {
    +
    +	private static final Logger LOG = LoggerFactory.getLogger(CreditBasedClientHandler.class);
    +
    +	/** Channels, which already requested partitions from the producers. */
    +	private final ConcurrentMap<InputChannelID, RemoteInputChannel> inputChannels
= new ConcurrentHashMap<>();
    +
    +	/** Channels, which will notify the producers about unannounced credit. */
    +	private final ArrayDeque<RemoteInputChannel> inputChannelsWithCredit = new ArrayDeque<>();
    +
    +	private final AtomicReference<Throwable> channelError = new AtomicReference<>();
    +
    +	private final ChannelFutureListener writeListener = new WriteAndFlushNextMessageIfPossibleListener();
    +
    +	/**
    +	 * Set of cancelled partition requests. A request is cancelled iff an input channel
is cleared
    +	 * while data is still coming in for this channel.
    +	 */
    +	private final ConcurrentMap<InputChannelID, InputChannelID> cancelled = new ConcurrentHashMap<>();
    +
    +	private volatile ChannelHandlerContext ctx;
    --- End diff --
    
    Thanks for continuing reviewing! :)
    
    I guess it is because this variable may be accessed by different threads.
    
    For task canceler thread, it needs to cancel partition request during releasing all resources,
meanwhile the `ctx` is initialized during channel active by netty thread. 


---

Mime
View raw message