flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From fhueske <...@git.apache.org>
Subject [GitHub] flink pull request #5019: [FLINK-7942] [table] Reduce aliasing in RexNodes
Date Wed, 15 Nov 2017 12:29:35 GMT
Github user fhueske commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5019#discussion_r151110174
  
    --- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/table/api/stream/table/OverWindowTest.scala
---
    @@ -203,19 +203,17 @@ class OverWindowTest extends TableTestBase {
             "DataStreamCalc",
             unaryNode(
               "DataStreamOverAggregate",
    -          unaryNode(
    -            "DataStreamCalc",
    -            streamTableNode(0),
    -            term("select", "a", "c", "proctime")
    -          ),
    +          streamTableNode(0),
    --- End diff --
    
    The new plan is less efficient, because a projection isn't pushed down anymore and a wider
row needs to be materialized in the over window.


---

Mime
View raw message