flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From twalthr <...@git.apache.org>
Subject [GitHub] flink pull request #4726: [FLINK-7678] [table] Support composite inputs for ...
Date Mon, 13 Nov 2017 13:35:38 GMT
Github user twalthr commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4726#discussion_r150539194
  
    --- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/table/expressions/UserDefinedScalarFunctionTest.scala
---
    @@ -89,6 +90,14 @@ class UserDefinedScalarFunctionTest extends ExpressionTestBase {
           "Nullable(f0)",
           "Nullable(f0)",
           "42")
    +
    +    // test row type input
    +    testAllApis(
    +      Func19('f11),
    +      "Func19(f11)",
    +      "Func19(f11)",
    +      "12,true,1,2,3"
    --- End diff --
    
    No flattening is happening here. It calls the `toString` method of `Row`. If it would
be flattened, then only the first field would be returned by the test base.


---

Mime
View raw message