flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tillrohrmann <...@git.apache.org>
Subject [GitHub] flink pull request #4729: [FLINK-7076] [ResourceManager] implement YARN stop...
Date Tue, 07 Nov 2017 09:13:33 GMT
Github user tillrohrmann commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4729#discussion_r149307271
  
    --- Diff: flink-yarn/src/main/java/org/apache/flink/yarn/YarnWorkerNode.java ---
    @@ -0,0 +1,47 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.flink.yarn;
    +
    +import org.apache.flink.runtime.clusterframework.types.ResourceID;
    +import org.apache.flink.runtime.clusterframework.types.ResourceIDRetrievable;
    +
    +import org.apache.hadoop.yarn.api.records.Container;
    +
    +import java.io.Serializable;
    +
    +/**
    + * A stored YARN worker, which contains the YARN container.
    + */
    +public class YarnWorkerNode implements ResourceIDRetrievable, Serializable {
    --- End diff --
    
    Remove the type constraint in `ResourceManager`, I would suggest.


---

Mime
View raw message