flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From NicoK <...@git.apache.org>
Subject [GitHub] flink pull request #4952: [FLINK-7992][docs] extend the PR template asking f...
Date Mon, 06 Nov 2017 12:51:56 GMT
Github user NicoK commented on a diff in the pull request:

    --- Diff: .github/PULL_REQUEST_TEMPLATE.md ---
    @@ -63,9 +63,9 @@ This change added tests and can be verified as follows:
       - The serializers: (yes / no / don't know)
       - The runtime per-record code paths (performance sensitive): (yes / no / don't know)
       - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing,
Yarn/Mesos, ZooKeeper: (yes / no / don't know)
    +  - The S3 file system connector: (yes / no / don't know)
    --- End diff --
    Wouldn't this be true for any of the points we ask users to fill out? In the end, there
should probably be a committer's guide (is there?) with more details on everything but for
the committer only - we don't want to scare the contributer away. 


View raw message